-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode to full name, disable Visual Studio Code plugin by default #10071
Conversation
@niels9001 |
let's rename |
A bit generic, but could work: Or just a monochrome version of the Visual Studio logo? |
@mykhailopylyp |
@htcfreek |
@niels9001 @mykhailopylyp |
As I understand you want to use the order to define the result prio. |
Yes. Ordering the plugins in the plugin manager would make sense if that order is also the order of priority in the results. |
Otherwise I thought we do it simply alphabetical. That's why I asked. |
Here are the icon assets (using the same dimensions and size as the other plugins), both .dark and .light |
Should be |
@niels9001 @htcfreek |
...s/launcher/Plugins/Community.PowerToys.Run.Plugin.VSCodeWorkspaces/Properties/Resources.resx
Outdated
Show resolved
Hide resolved
@mykhailopylyp |
I used them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better description suggestion.
Can you please post a pick of the expanded vs code plugin entry. Want to check something.
</data> | ||
<data name="In" xml:space="preserve"> | ||
<value>in</value> | ||
<comment>Used to indicate the location where something is</comment> | ||
</data> | ||
<data name="PluginDescription" xml:space="preserve"> | ||
<value>Open VSCode previously opened workspaces, remote machines (SSH or Codespaces) and containers.</value> | ||
<value>Opens VS Code's previously opened workspaces, remote machines (SSH or Codespaces) and containers.</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<value>Opens VS Code's previously opened workspaces, remote machines (SSH or Codespaces) and containers.</value> | |
<value>Lists and opens workspaces, remote machines (SSH or Codespaces) and containers, previously opened in VS Code.</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@htcfreek
good suggestion.
Do we need Lists and...
or can we just says Opens...
since all modules, in a way or in another, lists
something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@htcfreek
good suggestion.
Do we needLists and...
or can we just saysOpens...
since all modules, in a way or in another,lists
something.
@enricogior
Good point. To open them, I logical need a list. We could use only opens
or we could use something like Provides access to ...
which implies list and open too.
The important point that bothers me at the moment is, that in our productive description something seems to be/sounds wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will go just with Opens
as it is consistent with other plugins.
Updated description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's merge it!
Summary of the Pull Request
What is this about:
What is include in the PR:
How does someone test / validate:
PowerToys Run\settings.json
fileQuality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.